predicates/traffic: fix flaky TrafficSegment tests #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test failure could be reproduced via: ``` go test ./predicates/traffic/ -count=100 -run=TestTrafficSegmentSplit ``` * use delta of expected value instead of total number of test requests * use predefined number of test requests for all tests Based on the biggest difference seen for 1000 test requests: ``` Max difference between 500 and 462 allowed is 25, but difference was 38 ``` the delta should be 38/500=0.076 To reduce flakiness: * increase total number of samples to 10'000 * then increase delta to 6% based on the failed test case output Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
szuecs
reviewed
Jun 23, 2023
| // doN performs a number of requests and returns the number of responses for each status code and | ||
| // a total number of requests performed. | ||
| // Results use float64 type to simplify fractional comparisons. | ||
| func doN(t *testing.T, client *proxytest.TestClient, request func() *http.Request) (map[int]float64, float64) { |
There was a problem hiding this comment.
Where is the N?
Maybe better to call it do ?
There was a problem hiding this comment.
N is hardcoded, see below.
The name highlights that it does multiple requests
|
👍 |
1 similar comment
|
👍 |
|
|
||
| t.Logf("Response codes: %v", codes) | ||
|
|
||
| assert.InDelta(t, N*0.5, codes[200], delta) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test failure could be reproduced via:
Based on the biggest difference seen for 1000 test requests:
the delta should be 38/500=0.076
To reduce flakiness: