build: cleanup Makefile #2461
Merged
build: cleanup Makefile #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AlexanderYastrebov
commented
Jul 15, 2023
AlexanderYastrebov
commented
- remove unnecessary bin target
- remove bin directory during clean
- fix typo
- do not clean entire go build cache (see cmd/go: go clean should not accept flags like -modcache with packages golang/go#53725)
| @@ -112,11 +108,12 @@ lint: build staticcheck ## run all linters | |||
|
|
|||
| .PHONY: clean | |||
| clean: ## clean temporary files and directories | |||
| go clean -i -cache -testcache | |||
There was a problem hiding this comment.
-cache or -testcache flags remove entire go build cache.
golang/go#53725 added warning about it which we silenced in #2217
* remove unnecessary bin target * remove bin directory during clean * fix typo * do not clean entire go build cache (see golang/go#53725) Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
cleanup-makefile
branch
from
0bb2948 to
ff26924
Compare
alexandreliberato
approved these changes
Jul 16, 2023
|
👍 |
1 similar comment
|
👍 |
szuecs
reviewed
Jul 22, 2023
| @@ -22,25 +22,21 @@ help: ## Display this help | |||
| lib: $(SOURCES) ## build skipper library | |||
| go build ./... | |||
|
|
|||
| .PHONY: bindir | |||
| bindir: | |||
| mkdir -p bin | |||
There was a problem hiding this comment.
That's not so great because it breaks the build for new contributors
There was a problem hiding this comment.
No, bin is created by go build automatically (try e.g. make clean skipper)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.