adding Prometheus metric for Routes health #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We definitely don't expect this to be merged as is but wanted to get a PR up to make sure we're on the right track with how to wire the counters in. |
|
@szuecs @AlexanderYastrebov Wiring up the metric into the routing is a challenge, not a good idea at the moment. Happy to your feedback how a proper access would look like? |
universam1
force-pushed
the
promRoutesHealth
branch
2 times, most recently
from
104d03b to
a8566a5
Compare
universam1
changed the title
|
The metrics, combined with a diff threshold seem quite useful: |
universam1
force-pushed
the
promRoutesHealth
branch
from
a8566a5 to
4f3afcd
Compare
for Routes health of `routes.total` and `routes.updated_timestamp` gauges that will facilitate to define alerts if Skipper instances drift Signed-off-by: Samuel Lang <gh@lang-sam.de>
universam1
force-pushed
the
promRoutesHealth
branch
from
4f3afcd to
bd11d75
Compare
|
👍 |
1 similar comment
|
👍 |
|
Thank you @AlexanderYastrebov @szuecs @RomanZavodskikh for quick release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #2595
adding Prometheus metrics for Routes health of
routes-totalandroutes-last-updategauges that will allow to defines alerts if Skipper instances drift.