Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added FadeIn data inside endpointregistry #2611

Closed
wants to merge 1 commit into from
Closed

Added FadeIn data inside endpointregistry #2611

wants to merge 1 commit into from

Conversation

RomanZavodskikh
Copy link
Contributor

@RomanZavodskikh RomanZavodskikh commented Sep 21, 2023 •
edited
Loading

  • Added FadeIn data inside endpointregistry
  • Checking the data inside endpointegistry in *_test.go files.

RomanZavodskikh
RomanZavodskikh commented Sep 21, 2023
View reviewed changes
VERSION Outdated Show resolved Hide resolved
szuecs
szuecs reviewed Sep 25, 2023
View reviewed changes
proxy/fadeintesting_test.go Outdated Show resolved Hide resolved
Added FadeIn data inside endpointregistry
3135b50 
Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
@RomanZavodskikh
Copy link
Contributor Author

FadeIn* fields are per-route properties, not per-endpoint, so they should not reside in the endpointregistry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderYastrebov AlexanderYastrebov AlexanderYastrebov left review comments

@szuecs szuecs szuecs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomanZavodskikh @szuecs @AlexanderYastrebov