net/redistest: update go-redis client to work with redis:6 #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update https://github.com/redis/go-redis/releases/tag/v9.5.0 broke support of redis:6 Unfortunately we did not catch it because we updated test redis to redis:7 recently, see #2895 This change adds test to verify client supports both redis:6 and redis:7 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
| @@ -12,14 +12,23 @@ import ( | |||
| "github.com/testcontainers/testcontainers-go/wait" | |||
| ) | |||
|
|
|||
| type options struct { | |||
There was a problem hiding this comment.
Decided not to export for now
| @@ -15,3 +15,13 @@ func TestRedistest(t *testing.T) { | |||
| t.Fatalf("Failed to ping redis: %v", err) | |||
| } | |||
| } | |||
|
|
|||
| func TestRedistestRedis6(t *testing.T) { | |||
There was a problem hiding this comment.
This passes for 9.4.0 and 9.5.1 but fails for 9.5.0
|
👍 |
1 similar comment
|
👍 |
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update https://github.com/redis/go-redis/releases/tag/v9.5.0 broke support of redis:6
Unfortunately we did not catch it because we updated test redis to redis:7 recently, see #2895
This change adds test to verify client supports both redis:6 and redis:7
The issue seems to be redis/go-redis#2915