Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration resolution #1379

Open
vadeg opened this issue Apr 3, 2022 · 0 comments
Open

Configuration resolution #1379

vadeg opened this issue Apr 3, 2022 · 0 comments

Comments

@vadeg
Copy link
Contributor

vadeg commented Apr 3, 2022

The issue has been identified in #1289 (See this comment for details).

Zally rule sets use lightbend config and reference.conf files define configuration. These files as supposed to be used for default configuration values. When library reads configuration, it merges all properties from reference.conf files into one configuration. The merging order is undefined.

The problem appears when a developer wants to develop a new rule set which has overlapping configuration with one of existing rule sets. In this case the final value of overlapping configuration property is unknown. Developers can override property in the main configuration loaded by the library. In case of Zally it is rules-config.yaml in the zally-server module. This means that rule set specific configuration should be defined in zally-server (or another main configuration) which is not the right place.

The goal of this ticket to explore how the issue with overlapping configurations can be solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant