Add legacy hostnames validation and exceptions for specific audiences #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Exclude merchant specific hostnames from rule validation * Add and extension to return API audience from any API * Add `ApiAudience` enum. Fixes #1187
Codecov Report
@@ Coverage Diff @@
## master #1238 +/- ##
=========================================
Coverage 87.62% 87.62%
Complexity 85 85
=========================================
Files 69 69
Lines 978 978
Branches 71 71
=========================================
Hits 857 857
Misses 84 84
Partials 37 37 Continue to review full report at Codecov.
|
|
👍 |
tkrop
approved these changes
May 27, 2021
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update validation to Rule 224.
ApiAudienceenum.Fixes #1187