Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schedule): prevent panicking in loop_schedule routine #176

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

goshawk-3
Copy link
Contributor

@goshawk-3 goshawk-3 commented Dec 6, 2024

fixes #168

  • We must ensure that set_server_key is always configured for every computation thread.
    It was observed that when the number of computations is only one, the comps.par_iter executes this computation in the current thread. However, since broadcast invokes are triggered only for Rayon threads, the local_storage of the current thread is not initialized with the server key.
  • Additionally, to prevent blocking the Tokio executor, the Rayon execution is wrapped in spawn_blocking so .await allows us to yield.

@goshawk-3 goshawk-3 merged commit 5789b54 into main Dec 6, 2024
3 checks passed
@goshawk-3 goshawk-3 self-assigned this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Coprocessor] Intermittent Coprocessor Crashes
2 participants