Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native): ensure buckets use valid references #202

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

goshawk-3
Copy link
Contributor

@goshawk-3 goshawk-3 commented Dec 19, 2024

fixes #201

  • Previously, the variables declared by a “for” loop were created once and updated by each iteration. In Go 1.22, each iteration of the loop creates new variables, to avoid accidental sharing bugs. The transition support tooling described in the proposal continues to work in the same way it did in Go 1.2

  • Although, it's fixed in latest golang version, it's cheaper to avoid the bug.

Result:

DEBUG[12-19|10:13:58.842] Add operation                            module="fhevm:sync compute" op=FHE_TRIVIAL_ENCRYPT handle=29c43b..f40300
DEBUG[12-19|10:13:58.842] Add operation                            module="fhevm:sync compute" op=FHE_TRIVIAL_ENCRYPT handle=59b4f9..500300
DEBUG[12-19|10:13:58.842] Add operation                            module="fhevm:sync compute" op=FHE_MUL             handle=2d8a85..460300
INFO [12-19|10:13:58.842] Sending grpc request                     module="fhevm:sync compute" computations=3 "compressed ciphertexts"=2

@goshawk-3 goshawk-3 self-assigned this Dec 19, 2024
@goshawk-3 goshawk-3 merged commit ea7061e into main Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: hanlde multiple FHE operations in a single block
2 participants