Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: updates EncryptedERC20 and other versions inheriting #68

Merged
merged 10 commits into from
Nov 29, 2024
Merged

refactor: updates EncryptedERC20 and other versions inheriting #68

merged 10 commits into from
Nov 29, 2024

Conversation

PacificYield
Copy link
Contributor

@PacificYield PacificYield commented Nov 27, 2024 •
edited
Loading

This PR contains multiple changes.

  • Split TFHEErrors to a specific interface that contains TFHE-specific errors.
  • Use of ERC-6093 for ERC20-like errors and add checks for address(0) for approve function
  • Updates NatSpec for EncryptedErrors.sol
  • Add solhint for husky precommit hook
  • Unit tests for EncryptedErrors

@PacificYield PacificYield self-assigned this Nov 27, 2024
@PacificYield PacificYield force-pushed the updates-encrypted-erc20 branch from 046277e to 7952ebe Compare November 28, 2024 10:38
@PacificYield PacificYield force-pushed the updates-encrypted-erc20 branch 2 times, most recently from 5713f33 to 72296ee Compare November 28, 2024 14:33
@PacificYield PacificYield force-pushed the updates-encrypted-erc20 branch 6 times, most recently from 4ee560b to a8cb56a Compare November 29, 2024 09:09
@PacificYield PacificYield force-pushed the updates-encrypted-erc20 branch from a8cb56a to 2238f15 Compare November 29, 2024 09:42
@PacificYield PacificYield marked this pull request as ready for review November 29, 2024 10:25
jatZama
jatZama reviewed Nov 29, 2024
View reviewed changes
contracts/utils/EncryptedErrors.sol
if (indexCode > _TOTAL_NUMBER_ERROR_CODES) {
revert ErrorIndexInvalid();
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you skip a line here?

jatZama
jatZama reviewed Nov 29, 2024
View reviewed changes
contracts/utils/EncryptedErrors.sol
if (indexCode == 0) {
revert ErrorIndexIsNull();
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

jatZama
jatZama reviewed Nov 29, 2024
View reviewed changes
contracts/utils/EncryptedErrors.sol
if (indexCode == 0) {
revert ErrorIndexIsNull();
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, etc

@PacificYield PacificYield merged commit 1ed27eb into main Nov 29, 2024
1 check passed
@PacificYield PacificYield deleted the updates-encrypted-erc20 branch November 29, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jatZama jatZama jatZama approved these changes

Assignees

@PacificYield PacificYield

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PacificYield @jatZama