test: events for all contracts #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PacificYield
force-pushed
the
test/events
branch
from
3fa0aeb to
d1a19b4
Compare
PacificYield
force-pushed
the
test/events
branch
from
d1a19b4 to
0a9df24
Compare
Closed
PacificYield
force-pushed
the
test/events
branch
2 times, most recently
from
5ac37ce to
e59c01a
Compare
PacificYield
requested review from
immortal-tofu and
jatZama
and removed request for
immortal-tofu and
jatZama
PacificYield
changed the title
PacificYield
changed the title
PacificYield
force-pushed
the
test/events
branch
from
bd78b6a to
72d058f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
DelegateVotesChangedin Comp.sol (since it provides no additional information as changes in votes cannot be seen as they are encrypted --> https://github.com/compound-finance/compound-protocol/blob/master/contracts/Governance/Comp.sol#L47-L51)