feat: add ConfidentialVestingWallet/ConfidentialVestingWalletCliff #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PacificYield
changed the title
PacificYield
changed the title
PacificYield
force-pushed
the
feat/VestingWallet.sol
branch
3 times, most recently
from
e897ec7 to
c593586
Compare
PacificYield
force-pushed
the
feat/VestingWallet.sol
branch
from
c593586 to
7212873
Compare
PacificYield
changed the title
PacificYield
force-pushed
the
feat/VestingWallet.sol
branch
3 times, most recently
from
f9e27fd to
7501cdb
Compare
|
I prefer let @jatZama review it 🙏 |
PacificYield
force-pushed
the
feat/VestingWallet.sol
branch
from
7501cdb to
e536334
Compare
jatZama
reviewed
Dec 20, 2024
| */ | ||
| abstract contract ConfidentialVestingWallet { | ||
| /// @notice Emitted when tokens are released to the beneficiary address. | ||
| event ConfidentialERC20Released(); |
There was a problem hiding this comment.
why you didn't keep original OZ specs allowing different tokens? this event should then contain an address argument. It is always better to make standard contracts as generalizable as possible imo.
jatZama
reviewed
Dec 20, 2024
jatZama
reviewed
Dec 20, 2024
| IConfidentialERC20 public immutable CONFIDENTIAL_ERC20; | ||
|
|
||
| /// @notice Duration (in seconds). | ||
| uint64 public immutable DURATION; |
There was a problem hiding this comment.
can you instead keep OZ's specs, with private variable and public getter functions?
There was a problem hiding this comment.
I prefer not to adjust it (for now) because I like that immutable variables that are easy to be spotted. I don't get why OZ does it as such with public getter functions.
jatZama
reviewed
Dec 20, 2024
jatZama
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two Solidity contracts:
ConfidentialVestingWallet.solandConfidentialVestingWalletCliff.sol.