refactor: updates Gateway response #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PacificYield
force-pushed
the
updates-gateway-maxtimestamp
branch
2 times, most recently
from
889f779 to
cf401e1
Compare
PacificYield
force-pushed
the
updates-gateway-maxtimestamp
branch
from
cf401e1 to
22bf231
Compare
jatZama
reviewed
Dec 5, 2024
| VOTING_PERIOD = votingPeriod_; | ||
|
|
||
| /// @dev The maximum delay is set to 1 day. | ||
| if (maxDecryptionDelay_ > 86_400) { |
There was a problem hiding this comment.
Can you replace this value 86_400 with 1 daysto make it more readable?
PacificYield
force-pushed
the
updates-gateway-maxtimestamp
branch
from
22bf231 to
be9cd21
Compare
PacificYield
force-pushed
the
updates-gateway-maxtimestamp
branch
from
be9cd21 to
6f40aec
Compare
jatZama
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.