Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): check dependencies licenses with cargo-deny #1692

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Oct 17, 2024

Closes: zama-ai/tfhe-rs-internal#793

@soonum soonum added the ci label Oct 17, 2024
@soonum soonum requested a review from IceTDrinker October 17, 2024 09:17
@soonum soonum self-assigned this Oct 17, 2024
@cla-bot cla-bot bot added the cla-signed label Oct 17, 2024
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several question, I'm not clear on how everything works, could be worth documenting in our knowledge base

@@ -0,0 +1,4 @@

# cargo-vet audits file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this work for configuration ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo-vet needs it to perform the audit (store acquisition).

Comment on lines +8 to +14
allow = [
"MIT",
"BSD-3-Clause",
"ISC",
"Apache-2.0",
"Unicode-DFS-2016"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aquint-zama those are good to use ?

Comment on lines +1 to +5

# cargo-vet config file

[cargo-vet]
version = "0.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does the config work here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's auto generated on cargo vet init and refreshed after a run of cargo vet

supply-chain/imports.lock Show resolved Hide resolved
@IceTDrinker
Copy link
Member

until we understand how the files and configs function I'm a bit wary to merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants