-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): check dependencies licenses with cargo-deny #1692
base: main
Are you sure you want to change the base?
Conversation
b5b46f5
to
ce21845
Compare
ce21845
to
05e474a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several question, I'm not clear on how everything works, could be worth documenting in our knowledge base
@@ -0,0 +1,4 @@ | |||
|
|||
# cargo-vet audits file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does this work for configuration ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo-vet needs it to perform the audit (store acquisition).
allow = [ | ||
"MIT", | ||
"BSD-3-Clause", | ||
"ISC", | ||
"Apache-2.0", | ||
"Unicode-DFS-2016" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aquint-zama those are good to use ?
|
||
# cargo-vet config file | ||
|
||
[cargo-vet] | ||
version = "0.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does the config work here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's auto generated on cargo vet init
and refreshed after a run of cargo vet
until we understand how the files and configs function I'm a bit wary to merge this |
Closes: zama-ai/tfhe-rs-internal#793