Gemm-based packing ks #1859
Closed
Gemm-based packing ks #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backends/tfhe-cuda-backend/cuda/src/crypto/fast_packing_keyswitch.cuh
Outdated
Show resolved
Hide resolved
IceTDrinker
reviewed
Dec 9, 2024
andrei-stoian-zama
force-pushed
the
chore/as_optimize_pks_ml
branch
from
a000de7 to
8859f79
Compare
| #[test] | ||
| fn test_gpu_ciphertext_compression_fast_path() { | ||
| // these parameters are insecure | ||
| const PARAM_CUSTOM_FAST_PATH: ClassicPBSParameters = ClassicPBSParameters { |
There was a problem hiding this comment.
@IceTDrinker , @agnesLeroy here I added dummy parameters that use the fast path but have no correctness guarantee - thus I removed the and operation in the test so no PBS is done -> just encrypt/compress/extract/decrypt.
I hope this is ok, let me know.
| const PARAM_CUSTOM_FAST_PATH: ClassicPBSParameters = ClassicPBSParameters { | ||
| lwe_dimension: LweDimension(2048), | ||
| glwe_dimension: GlweDimension(1), | ||
| polynomial_size: PolynomialSize(2048), |
There was a problem hiding this comment.
should I add other poly sizes in the test ?
|
hey I've been very busy with noise verifications, I should have some time to review hopefully in the next few days, but I have a ZK review that will take priority |
|
Closed because I generalized this approach in #1875 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Achieves ~4x speedup for packing keyswitch