-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(shortint): new parameters #1886
Open
nsarlin-zama
wants to merge
9
commits into
main
Choose a base branch
from
ns/chore/params_zkv1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+9,137
−4,895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarlin-zama
force-pushed
the
ns/chore/params_zkv1
branch
2 times, most recently
from
December 17, 2024 15:07
25d6bb9
to
92ea542
Compare
tmontaigu
approved these changes
Dec 18, 2024
nsarlin-zama
force-pushed
the
ns/chore/params_zkv1
branch
from
December 19, 2024 15:09
92ea542
to
e7273ab
Compare
nsarlin-zama
changed the title
chore(shortint): new parameters for zkv1
chore(shortint): new parameters
Dec 19, 2024
nsarlin-zama
force-pushed
the
ns/chore/params_zkv1
branch
from
December 19, 2024 15:13
e7273ab
to
7a1e96e
Compare
Loading status checks…
nsarlin-zama
force-pushed
the
ns/chore/params_zkv1
branch
3 times, most recently
from
December 20, 2024 08:53
7858942
to
b173358
Compare
nsarlin-zama
force-pushed
the
ns/chore/params_zkv1
branch
2 times, most recently
from
December 20, 2024 10:41
9b313f2
to
0fab62b
Compare
Should we set aliases for Gaussian common parameters (like 2_2) just like the Tuniform flavour ? @IceTDrinker |
soonum
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible and tedious job, thanks a lot @nsarlin-zama !
Loading status checks…
nsarlin-zama
force-pushed
the
ns/chore/params_zkv1
branch
from
December 20, 2024 16:49
a26e7fc
to
325fe6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.