feat: add option to update all plugins at once #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamaraddio
requested changes
May 3, 2023
There was a problem hiding this comment.
Hi @LoneExile, thanks for your pull request.
Please merge zap:master into your branch to align the current state of Zap (there where some changes in last days).
In addition, to simplify and stay close to the actual "Zap style" please adopt the following approach:
Instead of lines 79-83 (if [[ "$1" == "-a" ...), please make the same with:
[[ $1 = "self" ]] && { _pull $ZAP_DIR; return }
[[ $1 = "all" ]] && { for _plug in ${ZAP_INSTALLED_PLUGINS[@]}; do _pull "$ZAP_PLUGIN_DIR/$_plug"; done; return }If you are interested take a look at this
LoneExile
added a commit
to LoneExile/zap
that referenced
this pull request
May 3, 2023
mamaraddio
pushed a commit
that referenced
this pull request
May 4, 2023
* feat(update): add flag (-a, --all) #123 * refactor: format code to "Zap style" * feat(update): add options all, self to update * feat(update): update usage zap_help * refactor: rm return value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
With this change, users can now run
zap update -ato update all installed plugins.I hope you find this feature helpful! As a personal anecdote, I often use an alias that updates everything on my machine, including
brewandzap. This change tozapwill make it even easier to update all my plugins without having to interrupt the process by typing a key.Thanks for considering my pull request!