fix: resolve two issues with the Zap installation script #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changes to the .zshrc file is made. fix: change the launch of a new zsh session to rather reread the .zshrc file to maintain variables, history and allow the install script to be launched from an automation script.
mamaraddio
reviewed
Apr 29, 2023
mamaraddio
added a commit
that referenced
this pull request
May 2, 2023
* fix: resolve two issues with the Zap installation script (#133) * feat: move the check to see if Zap is already installed to before any changes to the .zshrc file is made. fix: change the launch of a new zsh session to rather reread the .zshrc file to maintain variables, history and allow the install script to be launched from an automation script. * fix: change '.' to 'source' * feat: cleanup updating all plugins output (#135) --------- Co-authored-by: Matthew Winter <33818+wintermi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve the following two issues with the Zap installation script
Move the check to see if Zap is already installed to before any changes to the .zshrc file are made.
Change the launch of a new zsh session to rather reread the .zshrc file to maintain variables, history and allow the install script to be launched from an automation script. This resolves issue Disable automatic launch of a new zsh session after installation. #132