-
Notifications
You must be signed in to change notification settings - Fork 0
Improvements regarding system shutdown and usage of JavaTestKit #2
Comments
Hi! All suggestions and PR's are more than welcome ;-) Sondre
|
Great !
What do you think ? |
|
Well, I'll try to submit PR this weekend. |
Another aproach will be to extend the existing @rule and create a JavaTestKitRule that takes care of both startup and shutdown. The drawback is that you can have only one JavaTestKit instance per test. Would that cause any problems for you @eshepelyuk? |
I don't see any problem, just not clearly understand the benefits of creating a new |
I do think that a JavaTestKitRule will cover a lot of use cases as I suspect that many people need to create a JavaTestKit anyway. Having all the logic contained in a rule ensures that all resources are freed after the test has completed and also avoids code duplication in people's tests. |
…est more asynchronously. Somewhat relevant to issue #2
I have added a new TestKitRule and a test class to show how it may be used. It would be awesome if you would have a look at TestKitRuleTest and see if it indeed serves your use-cases. If you are satisfied I will create a new release ASAP |
Hello The code looks great, doing exactly what we've been missing.
Don't you think it's just rather confusing to pick up which one to choose ? |
Ok: that's a valid point. They are already almost identical. I'll keep the ActorSystemRule move the JavaTestKit functionality over there. I will look into it at some point in the comming days.. Anyway: thank you for your input |
Thanks for your work on this, waiting forward for the release :) |
As I just released v. 1.2.0 that contains the changes discussed in this ticket, I am closing it 👍 |
Unfortunately during shutdown it's not using This is usually a main cause of various bugs. Could you please add it ? |
Sure! Could you open a new github issue for that particular bug. It makes it On Fri, Sep 23, 2016 at 9:16 AM, Evgeny Shepelyuk notifications@github.com
|
Created Issue #5 |
Hello @zapodot
What is the Currently state of the project ? Are you still maintaining it ?
I have an idea for some improvement and PR
The text was updated successfully, but these errors were encountered: