show: Convert to using flagConfig()

Add a general cobra command PersistentPreRun that can be called by any lab
command, and convert the 'mr show' and 'issue show' commands to use
flagConfig().

Signed-off-by: Prarit Bhargava <prarit@redhat.com>

cmd/issue_show.go

@@ -18,11 +18,12 @@ import (
 )
 
 var issueShowCmd = &cobra.Command{
-	Use:        "show [remote] <id>",
-	Aliases:    []string{"get"},
-	ArgAliases: []string{"s"},
-	Short:      "Describe an issue",
-	Long:       ``,
+	Use:              "show [remote] <id>",
+	Aliases:          []string{"get"},
+	ArgAliases:       []string{"s"},
+	Short:            "Describe an issue",
+	Long:             ``,
+	PersistentPreRun: LabPersistentPreRun,
 	Run: func(cmd *cobra.Command, args []string) {
 
 		rn, issueNum, err := parseArgs(args)
@@ -44,9 +45,6 @@ var issueShowCmd = &cobra.Command{
 		printIssue(issue, rn, renderMarkdown)
 
 		showComments, _ := cmd.Flags().GetBool("comments")
-		if showComments == false {
-			showComments = getMainConfig().GetBool(CommandPrefix + "comments")
-		}
 		if showComments {
 			discussions, err := lab.IssueListDiscussions(rn, int(issueNum))
 			if err != nil {

cmd/mr_show.go

@@ -24,11 +24,12 @@ var (
 )
 
 var mrShowCmd = &cobra.Command{
-	Use:        "show [remote] <id>",
-	Aliases:    []string{"get"},
-	ArgAliases: []string{"s"},
-	Short:      "Describe a merge request",
-	Long:       ``,
+	Use:              "show [remote] <id>",
+	Aliases:          []string{"get"},
+	ArgAliases:       []string{"s"},
+	Short:            "Describe a merge request",
+	Long:             ``,
+	PersistentPreRun: LabPersistentPreRun,
 	Run: func(cmd *cobra.Command, args []string) {
 
 		rn, mrNum, err := parseArgs(args)
@@ -68,9 +69,6 @@ var mrShowCmd = &cobra.Command{
 		}
 
 		showComments, _ := cmd.Flags().GetBool("comments")
-		if showComments == false {
-			showComments = getMainConfig().GetBool(CommandPrefix + "comments")
-		}
 		if showComments {
 			discussions, err := lab.MRListDiscussions(rn, int(mrNum))
 			if err != nil {

cmd/util.go

@@ -6,6 +6,7 @@ import (
 	"strconv"
 	"strings"
 
+	"github.com/spf13/cobra"
 	flag "github.com/spf13/pflag"
 	"github.com/spf13/viper"
 	"github.com/zaquestion/lab/internal/config"
@@ -69,3 +70,7 @@ func textToMarkdown(text string) string {
 	text = strings.Replace(text, "\n", "  \n", -1)
 	return text
 }
+
+func LabPersistentPreRun(cmd *cobra.Command, args []string) {
+	flagConfig(cmd.Flags())
+}