create_common: add file for *_create common data

Some variables were being shared between snippet_ and project_create and it
wasn't clear which one was declaring which vars. This patch adds a file for
holding these common data.

Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>

cmd/create_common.go

@@ -0,0 +1,7 @@
+package cmd
+
+var (
+	private  bool
+	public   bool
+	internal bool
+)

cmd/fork.go

@@ -169,7 +169,7 @@ func init() {
 	forkCmd.Flags().StringP("name", "n", "", "fork project with a different name")
 	forkCmd.Flags().StringP("group", "g", "", "fork project in a different group (namespace)")
 	forkCmd.Flags().StringP("path", "p", "", "fork project with a different path")
-	// useHTTP is defined in "project_create.go"
+	// useHTTP is defined in "util.go"
 	forkCmd.Flags().BoolVar(&useHTTP, "http", false, "fork using HTTP protocol instead of SSH")
 	RootCmd.AddCommand(forkCmd)
 }

cmd/project_create.go

@@ -11,12 +11,6 @@ import (
 	lab "github.com/zaquestion/lab/internal/gitlab"
 )
 
-var (
-	// private and public are defined in snippet_create.go
-	internal bool
-	useHTTP  bool
-)
-
 // projectCreateCmd represents the create command
 var projectCreateCmd = &cobra.Command{
 	Use:   "create [path]",

cmd/snippet_create.go

@@ -21,10 +21,8 @@ import (
 )
 
 var (
-	name    string
-	file    string
-	private bool
-	public  bool
+	name string
+	file string
 )
 
 // mrCmd represents the mr command

cmd/util.go

@@ -22,6 +22,8 @@ import (
 
 var (
 	CommandPrefix string
+	// http vs ssh protocol control flag
+	useHTTP bool
 )
 
 // flagConfig compares command line flags and the flags set in the config