-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lab ci wait #240
Comments
I'm pretty sure we can pull this off! Thanks for including your usecase as well, that goes a long way in integrating your idea into lab as a whole and provide a tangible workflow to justify implementation. That said, have you looked at multi-project pipelines in GitLab? This may fit your usecase more elegantly that the feature would?? https://docs.gitlab.com/ee/ci/multi_project_pipelines.html -- Let me know! |
Yes, I looked at multi project pipelines, but they don't support our use case. |
@temp |
Looking good! |
Ah, some weirdness remains ;-)
Maybe the wait is already done, but he's still busy printing? |
Oh my! |
@temp Not sure what you may have ran into, but at least in my own usage of this:
Going to fix that, have you been able to gather any more info on what you may have ran into? Is it possible that you also needed to specify a separate pipeline? |
@zaquestion I started it from within my git-directory - then you don't need to specifiy the project! |
Ah, nice work around! I'll add the additional means as well soon |
I've also encountered this. |
Yep @claytonrcarter is right, my code was just bunk 😊 |
@bmeneguele works fine now! 👍 |
I'm glad to hear that :)
Hmm... a timeout behavior? That's something to think about indeed. |
Oh, no, I meant the wait time between 2 polls. Have seen the 1-second-wait in the sources. But for long running pipelines it would be ok to poll 5-15 seconds, to avoid hammering. Like I said, it's only a nice to have. |
Here is the snippet: // don't spam the api TOO much
time.Sleep(1 * time.Second) |
Yup, when I fixed this feature, I picked 1s out of thin air! Adding a flag to configure the polling interval would be a trivial change; a great first issue/PR. |
Ahh, got it! |
Per discussion in #240, lets just bump up the interval, totally open to putting it behind a flag, but in the context of waiting for a an entire pipeline to finish, 1s is clearly a bit too aggressive.
chore: (ci status) #240 bump up default wait interval
Per discussion in zaquestion#240, lets just bump up the interval, totally open to putting it behind a flag, but in the context of waiting for a an entire pipeline to finish, 1s is clearly a bit too aggressive.
I don't know wether or not this is possible, but it would be nice to have a ci command that simpy waits for the current pipeline to finish and then exits with status code 0 for success, and 1 for failure.
This would allow scripting of several pipelines that need to be run in a specific order. I know you can trigger builds inside a pipeline, but we need it the other way - like a listener.
This would allow something like this:
The text was updated successfully, but these errors were encountered: