Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git lab mr show should be able to show the actual MR #277

Closed
1ace opened this issue Jan 2, 2019 · 2 comments · Fixed by #413
Closed

git lab mr show should be able to show the actual MR #277

1ace opened this issue Jan 2, 2019 · 2 comments · Fixed by #413
Milestone
0.18.0

Comments

@1ace
Copy link
Contributor

1ace commented Jan 2, 2019

Right now git lab mr show only shows a summary with the MR title and description, and a couple meta-data, but not the content of the MR.

It would make it much more useful if there was an additional flag (say -p, --patch for instance) that would fetch the branch and show it the way git show ..$remote/$branch does.
(Bonus point for supporting --reverse or even making it the default, because the "anti-chronological order by default" of git show annoys me.)
@zaquestion
Copy link
Owner

Definitely something we want to support!

@MartinDelille
Copy link
Contributor

Detecting the current merge request is done in the lab mr browse command. We should factorize the code.

@1ace 1ace mentioned this issue Jan 29, 2019
Closed
prarit added a commit to prarit/lab that referenced this issue Sep 2, 2020
@prarit
[PATCH] Add --patch option to mr show
edb6b9b 
Fixes zaquestion#277

It would be nice to provide functionality that provides the patches
for an MR in 'git show' format.  This is useful for users that want
to quickly look at a patchset without checking out a branch.

The original patch provided by Eric required users to provide the
target remote, even if the target remote was "origin".  The additional
code provided by Prarit uses the fetch remote name in 'git remote -v'
by default unless the user specifies a specific remote.

Original patch from Eric, With modifications to automatically find the
target remote by Prarit.

Co-Developed-by: Eric Engestrom <eric.engestrom@intel.com>
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
prarit added a commit to prarit/lab that referenced this issue Sep 2, 2020
@prarit
[PATCH] Add --patch option to mr show
28c0350 
Fixes zaquestion#277 which requests functionality that provides the patches
for an MR in 'git show' format.  This is useful for users that want
to quickly look at a patchset without checking out a branch.

The original patch provided by Eric required users to provide the
target remote, even if the target remote was "origin".  The additional
code provided by Prarit uses the fetch remote name in 'git remote -v'
by default unless the user specifies a specific remote.

Original patch from Eric, with modifications to automatically find the
target remote by Prarit.

Add '--patch' option to 'mr show' that displays the patches for a merge
request in 'git show' format.

Co-Developed-by: Eric Engestrom <eric.engestrom@intel.com>
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
@prarit prarit mentioned this issue Sep 2, 2020
Merged
prarit added a commit to prarit/lab that referenced this issue Sep 2, 2020
@prarit
[PATCH] Add --patch option to mr show
5b8e470 
Fixes zaquestion#277 which requests functionality that provides the patches
for an MR in 'git show' format.  This is useful for users that want
to quickly look at a patchset without checking out a branch.

The original patch provided by Eric required users to provide the
target remote, even if the target remote was "origin".  The additional
code provided by Prarit uses the fetch remote name in 'git remote -v'
by default unless the user specifies a specific remote.

Original patch from Eric, with modifications to automatically find the
target remote by Prarit.

Add '--patch' option to 'mr show' that displays the patches for a merge
request in 'git show' format.

Co-Developed-by: Eric Engestrom <eric.engestrom@intel.com>
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
prarit added a commit to prarit/lab that referenced this issue Sep 2, 2020
@prarit
[PATCH] Add --patch option to mr show
6ce90a2 
Fixes zaquestion#277 which requests functionality that provides the patches
for an MR in 'git show' format.  This is useful for users that want
to quickly look at a patchset without checking out a branch.

The original patch provided by Eric required users to provide the
target remote, even if the target remote was "origin".  The additional
code provided by Prarit uses the fetch remote name in 'git remote -v'
by default unless the user specifies a specific remote.

Original patch from Eric, with modifications to automatically find the
target remote, and the test from Prarit.

Add '--patch' option to 'mr show' that displays the patches for a merge
request in 'git show' format.

Co-Developed-by: Eric Engestrom <eric.engestrom@intel.com>
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
@zaquestion zaquestion added this to the 0.18.0 milestone Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.18.0
Development

Successfully merging a pull request may close this issue.

[PATCH] Add --patch option to mr show prarit/lab
WIP: Add --patch option to mr show
3 participants
@1ace @MartinDelille @zaquestion