mr_merge: add option for merging immediately #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
=======================================
Coverage 55.70% 55.71%
=======================================
Files 76 76
Lines 4743 4744 +1
=======================================
+ Hits 2642 2643 +1
Misses 1843 1843
Partials 258 258
Continue to review full report at Codecov.
|
Today, the `lab mr merge` command set, by default, the option of merging only when pipeline succeeds, however, in some workflows (e.g. mine) it's not desirable: it's sometimes desirable a merge happens regardless the pipeline results, for many different reasons. This patch adds the `lab mr merge --immediate` (or `-i`) for immediately merge the MR. Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
bmeneg
force-pushed
the
feature-mr_merge-pipeline-succeeds
branch
from
93871f7
to
bc51d1b
Compare
bmeneg
changed the title
|
I´ve tested this change locally and using a container to run the full test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, the
lab mr mergecommand set, by default, the option of mergingonly when pipeline succeeds, however, in some workflows (e.g. mine) it's not
entirely true: it's sometimes desirable a merge happens regardless the
pipeline results, for many different reasons.
This patch adds the
lab mr merge --pipeline-succeeds(or-p) forenabling it, while the default now is to merge directly.
Signed-off-by: Bruno Meneguele bmeneg@redhat.com
Fixes #653