Skip to content

Commit

Permalink
revise comment
Browse files Browse the repository at this point in the history
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
  • Loading branch information
AustinAbro321 committed Oct 1, 2024
1 parent c5f8e8f commit 34bd56d
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/internal/packager/helm/chart.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,9 @@ func (h *Helm) InstallOrUpgradeChart(ctx context.Context) (types.ConnectStrings,
})
}
if !h.chart.NoWait {
// This effectively doubles the amount of time a timeout can take
// 15 minute timeout -> 14 minutes to install -> another 14 minutes of waiting
// This could be avoided by creating the context in the start of the retry loop
// Technically would be a breaking change, in practice this is unlikely to affect anyone
// This re-uses the timeout from helm. This will increase the total amount of time a timeout can take
// However it is unlikely this step will take long
// The other option is to use the same context with as the helm install, this gets tricky with retries
healthChecksCtx, cancel := context.WithTimeout(ctx, h.timeout)
defer cancel()
spinner.Updatef("Running health checks")
Expand Down

0 comments on commit 34bd56d

Please sign in to comment.