Enable errcheck linter

.golangci.yaml

@@ -3,6 +3,7 @@ run:
 linters:
   disable-all: true
   enable:
+    - errcheck
     - gosimple
     - govet
     - staticcheck
@@ -41,6 +42,12 @@ linters-settings:
       - name: unused-parameter
       - name: unreachable-code
       - name: redefines-builtin-id
+  errcheck:
+    exclude-functions:
+      - (*github.com/spf13/cobra.Command).Help
+      - (*github.com/spf13/cobra.Command).MarkFlagRequired
+      - (*github.com/spf13/pflag.FlagSet).MarkHidden
+      - (*github.com/spf13/pflag.FlagSet).MarkDeprecated
 issues:
   # Revive rules that are disabled by default.
   include:

src/cmd/connect.go

@@ -91,7 +91,10 @@ var (
 		Aliases: []string{"l"},
 		Short:   lang.CmdConnectListShort,
 		Run: func(_ *cobra.Command, _ []string) {
-			cluster.NewClusterOrDie().PrintConnectTable()
+			err := cluster.NewClusterOrDie().PrintConnectTable()
+			if err != nil {
+				message.Fatal(err, err.Error())
+			}
 		},
 	}
 )

src/cmd/internal.go

@@ -229,7 +229,10 @@ var createPackageRegistryToken = &cobra.Command{
 
 			state.ArtifactServer.PushToken = token.Sha1
 
-			c.SaveZarfState(state)
+			err = c.SaveZarfState(state)
+			if err != nil {
+				message.Fatal(err, err.Error())
+			}
 		}
 	},
 }

src/internal/agent/http/admission.go

@@ -108,6 +108,7 @@ func (h *admissionHandler) Serve(hook operations.Hook) http.HandlerFunc {
 
 		message.Infof(lang.AgentInfoWebhookAllowed, r.URL.Path, review.Request.Operation, result.Allowed)
 		w.WriteHeader(http.StatusOK)
+		// nolint: errcheck // ignore
 		w.Write(jsonResponse)
 	}
 }

src/internal/agent/http/proxy.go

@@ -26,6 +26,7 @@ func ProxyHandler() http.HandlerFunc {
 		if err != nil {
 			message.Debugf("%#v", err)
 			w.WriteHeader(http.StatusInternalServerError)
+			// nolint: errcheck // ignore
 			w.Write([]byte(lang.AgentErrUnableTransform))
 			return
 		}

src/internal/agent/http/server.go

@@ -60,6 +60,7 @@ func NewProxyServer(port string) *http.Server {
 func healthz() http.HandlerFunc {
 	return func(w http.ResponseWriter, _ *http.Request) {
 		w.WriteHeader(http.StatusOK)
+		// nolint: errcheck // ignore
 		w.Write([]byte("ok"))
 	}
 }

src/pkg/cluster/injector.go

@@ -169,7 +169,10 @@ func (c *Cluster) loadSeedImages(imagesDir, seedImagesDir string, injectorSeedSr
 			return seedImages, err
 		}
 
-		crane.SaveOCI(img, seedImagesDir)
+		err = crane.SaveOCI(img, seedImagesDir)
+		if err != nil {
+			return nil, err
+		}
 
 		seedImages = append(seedImages, ref)
 

src/pkg/cluster/namespace.go

@@ -15,5 +15,6 @@ func (c *Cluster) DeleteZarfNamespace() {
 	spinner := message.NewProgressSpinner("Deleting the zarf namespace from this cluster")
 	defer spinner.Stop()
 
+	// nolint: errcheck // Ignore until refactoring of k8s code is completed
 	c.DeleteNamespace(context.TODO(), ZarfNamespaceName)
 }

src/pkg/message/message.go

@@ -324,6 +324,7 @@ func Table(header []string, data [][]string) {
 		table = append(table, pterm.TableData{row}...)
 	}
 
+	// nolint:errcheck // never returns an error
 	pterm.DefaultTable.WithHasHeader().WithData(table).Render()
 }
 

src/pkg/packager/lint/lint.go

@@ -151,6 +151,7 @@ func fillComponentTemplate(validator *Validator, node *composer.Node, createOpts
 	// [DEPRECATION] Set the Package Variable syntax as well for backward compatibility
 	setVarsAndWarn(types.ZarfPackageVariablePrefix, true)
 
+	//nolint: errcheck // This error should bubble up
 	utils.ReloadYamlTemplate(node, templateMap)
 }
 

src/pkg/zoci/push.go

@@ -53,7 +53,10 @@ func (r *Remote) PublishPackage(ctx context.Context, pkg *types.ZarfPackage, pat
 
 	// assumes referrers API is not supported since OCI artifact
 	// media type is not supported
-	r.Repo().SetReferrersCapability(false)
+	err = r.Repo().SetReferrersCapability(false)
+	if err != nil {
+		return err
+	}
 
 	// push the manifest config
 	manifestConfigDesc, err := r.CreateAndPushManifestConfig(ctx, annotations, ZarfConfigMediaType)

src/test/external/ext_out_cluster_test.go

@@ -174,7 +174,8 @@ func (suite *ExtOutClusterTestSuite) Test_2_AuthToPrivateHelmChart() {
 		URL:      chartURL,
 	}
 	repoFile.Add(entry)
-	utils.WriteYaml(repoPath, repoFile, helpers.ReadWriteUser)
+	err = utils.WriteYaml(repoPath, repoFile, helpers.ReadWriteUser)
+	suite.NoError(err)
 
 	err = exec.CmdWithPrint(zarfBinPath, findImageArgs...)
 	suite.NoError(err, "Unable to find images, helm auth likely failed")
@@ -192,7 +193,8 @@ func (suite *ExtOutClusterTestSuite) createHelmChartInGitea(baseURL string, user
 	podinfoTarballPath := filepath.Join(tempDir, fmt.Sprintf("podinfo-%s.tgz", podInfoVersion))
 	suite.NoError(err, "Unable to package chart")
 
-	utils.DownloadToFile(fmt.Sprintf("https://stefanprodan.github.io/podinfo/podinfo-%s.tgz", podInfoVersion), podinfoTarballPath, "")
+	err = utils.DownloadToFile(fmt.Sprintf("https://stefanprodan.github.io/podinfo/podinfo-%s.tgz", podInfoVersion), podinfoTarballPath, "")
+	suite.NoError(err)
 	url := fmt.Sprintf("%s/api/packages/%s/helm/api/charts", baseURL, username)
 
 	file, err := os.Open(podinfoTarballPath)

src/test/nightly/ecr_publish_test.go

@@ -30,7 +30,8 @@ func TestECRPublishing(t *testing.T) {
 	t.Log("E2E: Testing component actions")
 
 	// Work from the root directory of the project
-	os.Chdir("../../../")
+	err := os.Chdir("../../../")
+	require.NoError(t, err)
 
 	// Create a tmpDir for us to use during this test
 	tmpDir := t.TempDir()