fix packager.HandleIfURL() tempPath early deletion

cli/cmd/package.go

@@ -31,8 +31,10 @@ var packageDeployCmd = &cobra.Command{
 	Short: "Deploys an update package from a local file or URL (runs offline)",
 	Args:  cobra.MaximumNArgs(1),
 	Run: func(cmd *cobra.Command, args []string) {
+		var done func()
 		packageName := choosePackage(args)
-		config.DeployOptions.PackagePath = packager.HandleIfURL(packageName, shasum, insecureDeploy)
+		config.DeployOptions.PackagePath, done = packager.HandleIfURL(packageName, shasum, insecureDeploy)
+		defer done()
 		packager.Deploy()
 	},
 }

cli/internal/packager/common.go

@@ -148,11 +148,11 @@ func getValidComponents(allComponents []types.ZarfComponent, requestedComponentN
 }
 
 // HandleIfURL If provided package is a URL download it to a temp directory
-func HandleIfURL(packagePath string, shasum string, insecureDeploy bool) string {
+func HandleIfURL(packagePath string, shasum string, insecureDeploy bool) (string, func()) {
 	// Check if the user gave us a remote package
 	providedURL, err := url.Parse(packagePath)
 	if err != nil || providedURL.Scheme == "" || providedURL.Host == "" {
-		return packagePath
+		return packagePath, func() {}
 	}
 
 	if !insecureDeploy && shasum == "" {
@@ -198,7 +198,7 @@ func HandleIfURL(packagePath string, shasum string, insecureDeploy bool) string
 		}
 	}
 
-	return localPackagePath
+	return localPackagePath, tempPath.clean
 }
 
 func isValidFileExtension(filename string) bool {