Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect grammar in src/types/k8s.go #1936

Closed
cmwylie19 opened this issue Aug 1, 2023 · 0 comments · Fixed by #1937
Closed

Incorrect grammar in src/types/k8s.go #1936

cmwylie19 opened this issue Aug 1, 2023 · 0 comments · Fixed by #1937
Assignees
@cmwylie19
Labels
possible-bug 🐛

Comments

@cmwylie19
Copy link
Contributor

Environment

Device and OS: all
App version:
Kubernetes distro being used:
Other:

Steps to reproduce

  1. https://github.com/defenseunicorns/zarf/blob/d1f9d898817f3bac38ecd9154d336270f6fa1761/src/types/k8s.go#L50
  2. https://github.com/defenseunicorns/zarf/blob/d1f9d898817f3bac38ecd9154d336270f6fa1761/src/types/k8s.go#L51

Expected result

If not provided for an external repository then the push-user is used

Actual Result

If not provided for an external repository than the push-user is used

Visual Proof (screenshots, videos, text, etc)

Severity/Priority

Additional Context

Add any other context or screenshots about the technical debt here.
@cmwylie19 cmwylie19 self-assigned this Aug 1, 2023
@cmwylie19 cmwylie19 mentioned this issue Aug 1, 2023
Merged
5 tasks
@Racer159 Racer159 changed the title Incorrect grammer in src/types/k8s.go Incorrect grammar in src/types/k8s.go Aug 1, 2023
Noxsios pushed a commit that referenced this issue Aug 1, 2023
@cmwylie19
grammar, than to then (#1937)
f4e5c8b 
## Description

In `src/types/k8s.go` we are using than when it should be then for
correct grammar

## Related Issue

Fixes #1936 
<!-- or -->
Relates to #

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwylie19 cmwylie19

Labels
possible-bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

grammar, than to then zarf-dev/zarf
1 participant
@cmwylie19