Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Plumb through context #2365

Closed
eddiezane opened this issue Mar 7, 2024 · 1 comment
Closed

refactor: Plumb through context #2365

eddiezane opened this issue Mar 7, 2024 · 1 comment
Assignees
@schristoff
Milestone
v0.38.0

Comments

@eddiezane
Copy link
Member

Describe what should be investigated or refactored

As of opening this issue there are ~50 uses of context.TODO throughout the codebase. We should refactor these library functions to accept a context.

Links to any relevant code

https://github.com/search?q=repo%3Adefenseunicorns%2Fzarf+NOT+path%3A*test*+context.TODO&type=code&p=1

Additional context

While we could create additional GetPodsWithContext functions it might be better to bite the bullet and make this as part of a breaking change.
@lucasrod16 lucasrod16 mentioned this issue Mar 26, 2024
Merged
5 tasks
lucasrod16 pushed a commit that referenced this issue May 15, 2024
@AustinAbro321
refactor: context usage in k8s code (#2405)
53465d7 
## Description
refactor context usage in k8s code

## Related Issue
Relates to #2365

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
@phillebaba
Copy link
Member

Relates to #2592 and #2594

@phillebaba phillebaba mentioned this issue Jul 11, 2024
Closed
@schristoff schristoff mentioned this issue Jul 20, 2024
Merged
AustinAbro321 added a commit that referenced this issue Jul 23, 2024
@AustinAbro321
refactor: context usage in k8s code (#2405)
8f891cc 
## Description
refactor context usage in k8s code

## Related Issue
Relates to #2365

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@schristoff schristoff self-assigned this Jul 30, 2024
@salaxander salaxander added this to the v0.38.0 milestone Aug 6, 2024
@salaxander salaxander closed this as completed by moving to Done in Zarf Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schristoff schristoff

Labels
None yet
Projects
Zarf
Status: Done
Milestone
v0.38.0
Development

No branches or pull requests
4 participants
@eddiezane @salaxander @phillebaba @schristoff