-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: enable -race flag for running unit tests in CI #2558
Comments
## Description Shutdown HTTP test servers with `Close()` ## Related Issue Noticed we aren't shutting down HTTP test servers in a couple of our unit tests while working on #2558 ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow) followed
pterm's Better concurrency pattern for LivePrinters #439 There is an open draft PR that is supposed to fix most of these issues, but it appears to be stale: Fix most data race issues & enable in CI tests #447 This means our tests will fail with the I will keep this issue open to track any progress on fixing the concurrency issues in pterm. |
## Description Shutdown HTTP test servers with `Close()` ## Related Issue Noticed we aren't shutting down HTTP test servers in a couple of our unit tests while working on #2558 ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow) followed Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Steps to reproduce
main
branch of the repository, run all of the unit tests with the-race
flag:Expected result
All unit tests pass
Actual Result
Unit tests fail due to data races
Visual Proof (screenshots, videos, text, etc)
The text was updated successfully, but these errors were encountered: