Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reimplement packager functions parent issue #2969

Open
4 of 14 tasks
schristoff opened this issue Sep 5, 2024 · 0 comments
Open
4 of 14 tasks

reimplement packager functions parent issue #2969

schristoff opened this issue Sep 5, 2024 · 0 comments
Assignees
Labels
tech-debt 💳 Debt that the team has charged and needs to repay
Milestone

Comments

@schristoff
Copy link
Contributor

schristoff commented Sep 5, 2024

Purpose:
As part of schema work it has been identified that src/packager intertwines "deploy time" and "package create time" logic. This makes it burdensome, or possibly impossible, to implement versioned schemas without passing a versioned structs throughout the codebase.

We will begin by refactoring the following pieces of src/packager into src/packager2 - this will allow us to re-implement this functionality without making breaking changes to Zarf in between releases. We will then swap over the calls to packager.() functions to packager2.() and deprecate src/packager functionality for src/packager2 (while renaming packager2 to packager)

Decisions Made:

  • To refactor "Opts" out of the larger Packager struct, Opts will be moved into their respective "primary file". All exported functions will take its "related" Opts struct as a function argument.
    E.g. - InspectOpts is moved into the inspect.go file within packager2

To Be Worked:

@schristoff schristoff added the tech-debt 💳 Debt that the team has charged and needs to repay label Sep 5, 2024
This was referenced Sep 16, 2024
@salaxander salaxander added this to the v0.41.0 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt 💳 Debt that the team has charged and needs to repay
Projects
Status: In progress
Development

No branches or pull requests

3 participants