Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove #3008

Merged
merged 1 commit into from
Sep 23, 2024
Merged

refactor: remove #3008

merged 1 commit into from
Sep 23, 2024

Conversation

phillebaba
Copy link
Member

Description

Refactors remove command.

Related Issue

Relates to #2969

Checklist before merging

@netlify Netlify
Copy link

netlify bot commented Sep 19, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 7fa1a55
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66f1ceaba0080f0008f791c6

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 9.49367% with 143 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/remove.go 0.00% 82 Missing ⚠️
src/pkg/cluster/zarf.go 0.00% 44 Missing ⚠️
src/cmd/package.go 0.00% 11 Missing ⚠️
src/internal/packager2/load.go 71.42% 3 Missing and 3 partials ⚠️
Files with missing lines Coverage Δ
src/internal/packager2/load.go 55.03% <71.42%> (+3.47%) ⬆️
src/cmd/package.go 0.00% <0.00%> (ø)
src/pkg/cluster/zarf.go 16.04% <0.00%> (-3.16%) ⬇️
src/internal/packager2/remove.go 0.00% <0.00%> (ø)

@phillebaba phillebaba force-pushed the refactor/remove branch 6 times, most recently from 371bc06 to 78ce3dc Compare September 20, 2024 13:41
@phillebaba phillebaba force-pushed the refactor/remove branch 13 times, most recently from e6f868e to f56a88e Compare September 23, 2024 08:53
@phillebaba phillebaba marked this pull request as ready for review September 23, 2024 09:22
@phillebaba phillebaba requested review from a team as code owners September 23, 2024 09:22
schristoff
schristoff previously approved these changes Sep 23, 2024
View reviewed changes
src/internal/packager2/remove.go Outdated Show resolved Hide resolved
src/internal/packager2/remove.go Outdated Show resolved Hide resolved
src/internal/packager2/remove.go Show resolved Hide resolved
@phillebaba
refactor: remove
7fa1a55 
Signed-off-by: Philip Laine <philip.laine@gmail.com>
@phillebaba phillebaba added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 22531dd Sep 23, 2024
28 checks passed
@phillebaba phillebaba deleted the refactor/remove branch September 23, 2024 21:20
ittacco pushed a commit to ittacco/zarf that referenced this pull request Nov 9, 2024
@phillebaba @ittacco
refactor: remove (zarf-dev#3008)
68dce61 
Signed-off-by: Philip Laine <philip.laine@gmail.com>
Signed-off-by: ittacco <lorenzo.tacconi1967@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinAbro321 AustinAbro321 AustinAbro321 left review comments

@schristoff schristoff schristoff approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phillebaba @schristoff @AustinAbro321