Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 2nd E2E test #110

Merged
merged 10 commits into from
Oct 19, 2021
Merged

Add a 2nd E2E test #110

merged 10 commits into from
Oct 19, 2021

Conversation

RothAndrew
Copy link
Contributor

@RothAndrew RothAndrew commented Oct 18, 2021

What/Why

  • Add e2e-general-cli test and GHA job - starting to test more of the e2e.sh with the goal being to completely cover what e2e.sh did so it can be deleted.

#106 should be merged first. This is a branch-of-a-branch starting at #106

@RothAndrew RothAndrew self-assigned this Oct 18, 2021
@RothAndrew RothAndrew marked this pull request as ready for review October 18, 2021 18:50
@RothAndrew RothAndrew marked this pull request as draft October 18, 2021 18:50
@RothAndrew
Copy link
Contributor Author

/test all

# Conflicts:
#	.github/workflows/test-command.yml
#	Makefile
#	test/e2e/e2e_example_game_test.go
@RothAndrew RothAndrew marked this pull request as ready for review October 19, 2021 19:56
# Conflicts:
#	.github/workflows/test-command.yml
#	Makefile
#	test/e2e/e2e_example_game_test.go
@RothAndrew
Copy link
Contributor Author

/test all

@RothAndrew RothAndrew enabled auto-merge (squash) October 19, 2021 20:00
@RothAndrew RothAndrew disabled auto-merge October 19, 2021 20:17
@RothAndrew RothAndrew merged commit d1acc0e into master Oct 19, 2021
@RothAndrew RothAndrew deleted the feature/add-another-e2e-test-2 branch October 19, 2021 20:17
jeff-mccoy pushed a commit that referenced this pull request Feb 8, 2022
Signed-off-by: Jeff McCoy <code@jeffm.us>
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Signed-off-by: Jeff McCoy <code@jeffm.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants