-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a 2nd E2E test #110
Merged
Merged
Add a 2nd E2E test #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RothAndrew
requested review from
jeff-mccoy,
btlghrants,
matt-strong and
YrrepNoj
October 18, 2021 18:49
/test all |
# Conflicts: # .github/workflows/test-command.yml # Makefile # test/e2e/e2e_example_game_test.go
# Conflicts: # .github/workflows/test-command.yml # Makefile # test/e2e/e2e_example_game_test.go
/test all |
YrrepNoj
approved these changes
Oct 19, 2021
jeff-mccoy
pushed a commit
that referenced
this pull request
Feb 8, 2022
Signed-off-by: Jeff McCoy <code@jeffm.us>
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
Signed-off-by: Jeff McCoy <code@jeffm.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why
e2e-general-cli
test and GHA job - starting to test more of thee2e.sh
with the goal being to completely cover whate2e.sh
did so it can be deleted.#106 should be merged first. This is a branch-of-a-branch starting at #106