Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubescape version in Big Bang Core example #111

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Update kubescape version in Big Bang Core example #111

merged 2 commits into from
Oct 25, 2021

Conversation

RothAndrew
Copy link
Contributor

What/Why

  • Update the kubescape version in the Big Bang Core example
  • I switched back to the binaries to GitHub sources since they seem to be doing immutable releases now. I'd love to not have to manage the binaries ourselves in our S3 bucket. I'm okay with switching it back to using the S3 bucket if anyone is uncomfortable with that change

@RothAndrew RothAndrew requested a review from jeff-mccoy October 18, 2021 21:42
@RothAndrew RothAndrew self-assigned this Oct 18, 2021
@RothAndrew RothAndrew marked this pull request as ready for review October 18, 2021 21:42
@RothAndrew
Copy link
Contributor Author

/test all

@RothAndrew
Copy link
Contributor Author

@jeff-mccoy I do you want you to look at this one since it changes back to pulling the kubescape files from github rather than our S3 bucket. Need to make sure you are cool with that.

@RothAndrew
Copy link
Contributor Author

/test all

jeff-mccoy
jeff-mccoy reviewed Oct 25, 2021
View reviewed changes
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we resolve the mutability issue with GitHub artifacts they release? I only want to ensure things don’t break with their changes.

@RothAndrew
Copy link
Contributor Author

They assured me they did, I'm inclined to trust them on that for now, and re-evaluate if it ever breaks again.

@jeff-mccoy
Copy link
Contributor

Okay great just saw the “latest” name and was worried. Otherwise LGTM.

@RothAndrew
Copy link
Contributor Author

Okay great just saw the “latest” name and was worried. Otherwise LGTM.

That's just how they name their artifacts, totally agree though that that's odd for them to have the word latest in the name of the file. It's definitely pinned to a specific release.

@RothAndrew RothAndrew merged commit 5ba2877 into master Oct 25, 2021
@RothAndrew RothAndrew deleted the feature/update-kubescape branch October 25, 2021 22:45
jeff-mccoy pushed a commit that referenced this pull request Feb 8, 2022
@RothAndrew @jeff-mccoy
Update kubescape version in Big Bang Core example (#111)
b9dfe3f 
Signed-off-by: Jeff McCoy <code@jeffm.us>
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
@RothAndrew @jeff-mccoy
Update kubescape version in Big Bang Core example (#111)
b3cfcc7 
Signed-off-by: Jeff McCoy <code@jeffm.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-mccoy jeff-mccoy jeff-mccoy approved these changes

Assignees

@RothAndrew RothAndrew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RothAndrew @jeff-mccoy