Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove git caching in favor of file:// #1398

Merged
merged 7 commits into from
Mar 2, 2023
Merged

Remove git caching in favor of file:// #1398

merged 7 commits into from
Mar 2, 2023

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Mar 1, 2023

Description

This removes git-caching behavior from Zarf in favor of folks controlling their repos manually with file:// now that that is supported.

Related Issue

Fixes #1362

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@Racer159 Racer159 added needs-docs PR Label - Docs required to merge needs-tests PR Label - Tests required to merge labels Mar 1, 2023
@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 0bd116f
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/63ffe1a177c85900077fc73d

@Racer159 Racer159 requested a review from Madeline-UX as a code owner March 1, 2023 23:25
@Racer159 Racer159 removed needs-docs PR Label - Docs required to merge needs-tests PR Label - Tests required to merge labels Mar 1, 2023
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ lgtm. Really like the FAQ / example addition and the test changes make sense.

@Racer159 Racer159 enabled auto-merge (squash) March 1, 2023 23:52
@Racer159 Racer159 merged commit 1b3c378 into main Mar 2, 2023
@Racer159 Racer159 deleted the remove-git-caching branch March 2, 2023 00:00
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
## Description

This removes git-caching behavior from Zarf in favor of folks
controlling their repos manually with `file://` now that that is
supported.

## Related Issue

Fixes #1362 

## Type of change

- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
This removes git-caching behavior from Zarf in favor of folks
controlling their repos manually with `file://` now that that is
supported.

Fixes #1362

- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed
Racer159 added a commit that referenced this pull request Mar 8, 2023
This removes git-caching behavior from Zarf in favor of folks
controlling their repos manually with `file://` now that that is
supported.

Fixes #1362

- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants