Switch to per-image tunnels, CRC on tags, and progressbar for image pushes #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
✅ Deploy Preview for zarf-docs canceled.
|
Racer159
changed the title
YrrepNoj
reviewed
Apr 12, 2023
YrrepNoj
reviewed
Apr 18, 2023
YrrepNoj
previously approved these changes
Apr 18, 2023
YrrepNoj
approved these changes
Apr 18, 2023
This was referenced Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a tunnel per image push (making it easier to implement concurrency - may do that in this PR if we can confirm that issues are mitigated) moves the CRC from the image name to the tag and changes the UI to use a progressbar instead of a spinner for better user feedback.
Related Issue
Relates to #1568 , #1433, #1218, #1364
This also will make #1594 slightly easier.
(See aws/containers-roadmap#853)
Fixes: #1541
Type of change
Checklist before merging