Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discover jobs/hooks in find images and diff git repo patches #1645

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Discover jobs/hooks in find images and diff git repo patches #1645

merged 2 commits into from
Apr 25, 2023

Conversation

Racer159
Copy link
Contributor

Description

Implements hook discovery for images and shows changes from patch-git.

Related Issue

Fixes #1246
Relates to #1625

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Apr 24, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit ee060a4
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/644845de97ea8a000847c153

@Racer159 Racer159 mentioned this pull request Apr 24, 2023
Closed
Noxsios
Noxsios approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@Noxsios Noxsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only thing I would change is colorizing the diff output, but thats a trivial change in the future.

src/pkg/message/message.go Show resolved Hide resolved
@Racer159 Racer159 merged commit 6ef3b49 into main Apr 25, 2023
@Racer159 Racer159 deleted the 1625-improve-prepare-commands branch April 25, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noxsios Noxsios Noxsios approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@YrrepNoj YrrepNoj Awaiting requested review from YrrepNoj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FindImages doesn't run any images found in Job Hooks
2 participants
@Racer159 @Noxsios