Fix: Failing Big Bang 2.0 Deployments #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willswire
requested review from
jeff-mccoy,
YrrepNoj,
Racer159 and
Noxsios
as code owners
✅ Deploy Preview for zarf-docs canceled.
|
willswire
changed the title
YrrepNoj
previously approved these changes
Apr 25, 2023
dgershman
reviewed
Apr 25, 2023
YrrepNoj
approved these changes
Apr 25, 2023
|
I read “Some of these keys already changed in BB 1.x, but had backwards compatibility previously.”
From: Danny Gershman ***@***.***>
Date: Tuesday, April 25, 2023 at 4:22 PM
To: defenseunicorns/zarf ***@***.***>
Cc: Danny Gershman ***@***.***>, Your activity ***@***.***>
Subject: Re: [defenseunicorns/zarf] Fix: Failing Big Bang 2.0 Deployments (PR #1648)
@dgershman commented on this pull request.
________________________________
In src/extensions/bigbang/manifests.go<#1648 (comment)>:
@@ -67,7 +67,7 @@ func manifestZarfCredentials(version string) corev1.Secret {
values := bbV1ZarfCredentialsValues
semverVersion, err := semver.NewVersion(version)
- if err != nil && semverVersion.Major() == 2 {
+ if err == nil && semverVersion.Major() == 2 {
values = bbV2ZarfCredentialsValues
Nevermind, it wasn't for all of them.
—
Reply to this email directly, view it on GitHub<#1648 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAOD3O6TCZLQQBYQD43KL7TXDAW75ANCNFSM6AAAAAAXLKDX2U>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Yup this is one of them that isn’t .
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Wayne Starr ***@***.***>
Sent: Tuesday, April 25, 2023 4:25:42 PM
To: defenseunicorns/zarf ***@***.***>
Cc: Danny Gershman ***@***.***>; Mention ***@***.***>
Subject: Re: [defenseunicorns/zarf] Fix: Failing Big Bang 2.0 Deployments (PR #1648)
@Racer159 commented on this pull request.
________________________________
In src/extensions/bigbang/manifests.go<#1648 (comment)>:
@@ -67,7 +67,7 @@ func manifestZarfCredentials(version string) corev1.Secret {
values := bbV1ZarfCredentialsValues
semverVersion, err := semver.NewVersion(version)
- if err != nil && semverVersion.Major() == 2 {
+ if err == nil && semverVersion.Major() == 2 {
values = bbV2ZarfCredentialsValues
(I was going off of the latest values.yaml for 1.57.1 which still uses kyvernopolicies https://repo1.dso.mil/big-bang/bigbang/-/blob/1.57.1/chart/values.yaml#L412)
—
Reply to this email directly, view it on GitHub<#1648 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAOD3O3CXYBMO2FUQMMMGC3XDAXMNANCNFSM6AAAAAAXLKDX2U>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@willswire first PR!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It appears that there is a mistake in the error handling of the semver.NewVersion function. It should be checking for no error instead of error. Found with @ragingpastry
Related Issue
Fixes #
Relates to #
Type of change
Checklist before merging