Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Update when to where in walkthrough docs #1660

Merged
merged 1 commit into from
May 1, 2023
Merged

[TASK] Update when to where in walkthrough docs #1660

merged 1 commit into from
May 1, 2023

Conversation

cmwylie19
Copy link
Contributor

Description

Just a small doc correction. Closes #1658

Related Issue

Fixes #1658

Relates to #1658

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Apr 28, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 6899b04
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/644d139eb653420008697f56
😎 Deploy Preview https://deploy-preview-1660--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Racer159
Racer159 reviewed Apr 29, 2023
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but there are merge conflicts due to some walkthrough updates that went out today - that error is still on the now helm-oci deployment walkthrough though. And thanks for the PR!

[TASK] Merge in new changes
6899b04 
Signed-off-by: Casey Wylie <cwylie@redhat.com>
@cmwylie19
Copy link
Contributor Author

Looks good to me but there are merge conflicts due to some walkthrough updates that went out today - that error is still on the now helm-oci deployment walkthrough though. And thanks for the PR!

My fault, you are right! Just rebased. My pleasure!

Racer159
Racer159 approved these changes Apr 30, 2023
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Noxsios
Noxsios approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@Noxsios Noxsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as well 👍

@Racer159 Racer159 merged commit 4ffed6a into zarf-dev:main May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noxsios Noxsios Noxsios approved these changes

@Racer159 Racer159 Racer159 approved these changes

@Madeline-UX Madeline-UX Awaiting requested review from Madeline-UX

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@YrrepNoj YrrepNoj Awaiting requested review from YrrepNoj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small Docs Issue, change when to where
3 participants
@cmwylie19 @Racer159 @Noxsios