-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kube version override #1662
Kube version override #1662
Conversation
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good - one other change could be to line 160 of src/pkg/packager/prepare.go
to change:
message.Errorf(err, "Problem rendering the helm template for %s", chart.URL)
to something like:
message.Errorf(err, "Problem rendering the helm template for %s: %s", chart.URL, err.Error())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
Adding a flag to the
zarf prepare find-images
command such that helm charts that implement a minimumkubeVersion
field in theChart.yaml
can specify an override target Kubernetes version. That will allowzarf prepare find-images
to specify a--kube-version
that emulates the same activity that helm uses forhelm template
.Related Issue
Fixes #1607
Type of change
Checklist before merging