Expose PVC accessMode as variable #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willswire
requested review from
jeff-mccoy,
YrrepNoj,
Racer159 and
Noxsios
as code owners
✅ Deploy Preview for zarf-docs canceled.
|
Racer159
requested changes
May 2, 2023
willswire
changed the title
|
We have pod affinity defined because this is node-attached storage and even a deployment rollout can break it if you don't tie the pod to the same node. HPA is no different than deployment rollout and does not require RWX. |
|
Reopening this PR after some |
Racer159
requested changes
May 3, 2023
willswire
changed the title
|
Twas missing |
Racer159
approved these changes
May 8, 2023
YrrepNoj
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When attempting to upgrade our EKS Node AMIs in AWS, we noticed that the Zarf Registry deployment was unable to horizontally scale across nodes which needed to restart. We believe the culprit is the
accessModespecification for the PersistentVolumeController. In order for multiple pods to have access to the same PersistentVolume, theaccessModemust be set to "ReadWriteMany".This PR proposes that when autoscaling is enabled for the Zarf Registry, theaccessModeis set to "ReadWriteMany" by default; when autoscaling is disabled, it is set to "ReadWriteOnce". Due to the additional work required (i.e. using an existing PersistencVolumeController with a storage class compatible with RWX), we also propose thatautoscalingbe disabled by default.This PR exposes the
REGISTRY_PVC_ACCESS_MODEvariable for thezarf-registryportion of the init package.Related Issue
Type of change
Checklist before merging