Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zarf resource adoption tutorial #1691

Merged
merged 15 commits into from
May 15, 2023
Merged

Add zarf resource adoption tutorial #1691

merged 15 commits into from
May 15, 2023

Conversation

JasonvanBrackel
Copy link
Contributor

Description

Adds a tutorial to show the zarf resource adoption feature from v0.26.1

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented May 10, 2023

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit a79a658
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/646280ab440f16000815a9a1
😎 Deploy Preview https://deploy-preview-1691--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

docs/6-zarf-tutorials/9-resource-adoption.md Outdated Show resolved Hide resolved
docs/6-zarf-tutorials/9-resource-adoption.md Outdated Show resolved Hide resolved
docs/6-zarf-tutorials/9-resource-adoption.md Outdated Show resolved Hide resolved
docs/6-zarf-tutorials/9-resource-adoption.md Outdated Show resolved Hide resolved
docs/6-zarf-tutorials/9-resource-adoption.md Outdated Show resolved Hide resolved
JasonvanBrackel and others added 6 commits May 12, 2023 12:07
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
@JasonvanBrackel JasonvanBrackel requested a review from Racer159 May 12, 2023 18:43
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The raw code looks fine but the caution is messed up (needs a space above it I think)
image

Also might be worth sizing the iframes - the namespace one talking about the zarf.dev/agent=ignore label is a little short.

ottok and others added 4 commits May 15, 2023 11:06
## Description

To make the docs more appealing to WordPress users spell the software
name correctly with a capital P.

See e.g.
https://developer.wordpress.org/reference/functions/capital_p_dangit/

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------
## Description

Improve the SBOM information that we have in our documentation.

## Related Issue

Fixes #1595
Fixes #1653

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed
@JasonvanBrackel JasonvanBrackel requested a review from Racer159 May 15, 2023 15:07
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 enabled auto-merge (squash) May 15, 2023 18:45
@Racer159 Racer159 merged commit 95777d0 into zarf-dev:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants