Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure variables are uppercase #1728

Merged
merged 2 commits into from
May 18, 2023
Merged

Conversation

YrrepNoj
Copy link
Contributor

If there are variables in a config.json/toml and variables provided via the --set flag we need to ensure both the variable keys are uppercase before processing and templating them. At the moment we were only uppercasing the config file variable keys which resulted in inconsistent behavior because of the indeterministic ordering of maps as we were looking for the variable's value.

Fixes #1726

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 939232b
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/64656d08390b000008fb19c1

Copy link
Contributor

@Noxsios Noxsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved! @YrrepNoj w/ the fastest debugging in the west 🥇 🍪

@Noxsios Noxsios enabled auto-merge (squash) May 18, 2023 00:10
@Noxsios Noxsios merged commit dc5d064 into main May 18, 2023
@Noxsios Noxsios deleted the 1726-intermittent-variable-applications branch May 18, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

intermittent issue: zarf package deploy --set value is not honored
2 participants