New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1168 review docs examples #1741

Merged

Racer159 merged 87 commits into main from 1168-review-docs-examples

Jun 1, 2023

Contributor

Noxsios commented May 22, 2023 •

edited

Loading

Description

Ok, so I started out w/ the full intention of just reviewing examples + cleaning up some of the test code to put kubectl get's as wait actions within their source zarf.yamls. Pretty good intentions right?! Well you know what they say about roads and good intentions...

Related Issue

Fixes #1168

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Other (security config, docs update, etc)

Checklist before merging

Test, docs, adr added or updated as needed
Contributor Guide Steps followed

Noxsios added 3 commits

May 22, 2023 12:02


          update bb yolo example

d8d3856

Signed-off-by: razzle <harry@razzle.cloud>


          add wait-for to zarf init pkg

77b4bc2

Signed-off-by: razzle <harry@razzle.cloud>


          more waits

5eb23e9

Signed-off-by: razzle <harry@razzle.cloud>

Noxsios linked an issue

that may be closed by this pull request

Review Docs Examples #1168

Closed

7 tasks

netlify bot commented May 22, 2023 •

edited

Loading

✅ Deploy Preview for zarf-docs canceled.

Name	Link
🔨 Latest commit	`8a27b01`
🔍 Latest deploy log	https://app.netlify.com/sites/zarf-docs/deploys/6478bf3edeaa2d00083796fd

Noxsios added 7 commits

May 22, 2023 13:48


          Merge branch 'main' into 1168-review-docs-examples

8cdd095


          more waits

17cbe0b

Signed-off-by: razzle <harry@razzle.cloud>


          lint

d9eb91a

Signed-off-by: razzle <harry@razzle.cloud>


          consistent quoting

9393b44

Signed-off-by: razzle <harry@razzle.cloud>


          better calling of zarf cli in upgrade_test

f0191e8

Signed-off-by: razzle <harry@razzle.cloud>


          update examples

27c67b4

Signed-off-by: razzle <harry@razzle.cloud>


          Merge branch 'main' into 1168-review-docs-examples

25fee89

Contributor

Racer159 commented May 23, 2023

@Noxsios one thing to also add to this is to have an example that actually shows the kustomizations field (we don't use it or show it off anywhere)

Contributor Author

Noxsios commented May 23, 2023 •

edited

Loading

https://docs.zarf.dev/examples/remote-manifests/

Noxsios added 16 commits

May 23, 2023 12:23


          o boi

ab49d8d

Signed-off-by: razzle <harry@razzle.cloud>


          e2e.ZarfWithConfirm

857aa35

Signed-off-by: razzle <harry@razzle.cloud>


          tests

a1dc7a4

Signed-off-by: razzle <harry@razzle.cloud>


          remove test from dir name

e307fca

Signed-off-by: razzle <harry@razzle.cloud>


          tests

c7f123c

Signed-off-by: razzle <harry@razzle.cloud>


          tests

c7bcc7b

Signed-off-by: razzle <harry@razzle.cloud>


          tests

950555e

Signed-off-by: razzle <harry@razzle.cloud>


          merge 03 w/ 00

1f5f5db

Signed-off-by: razzle <harry@razzle.cloud>


          remove e2e.cleanup

161a8f9

Signed-off-by: razzle <harry@razzle.cloud>


          v1.0.0 --> 1.0.0

8e51487

Signed-off-by: razzle <harry@razzle.cloud>


          parallelize test 00

5f77493

Signed-off-by: razzle <harry@razzle.cloud>


          tets

cbfaa50

Signed-off-by: razzle <harry@razzle.cloud>


          move 40 and 41 to 02

66508b5

Signed-off-by: razzle <harry@razzle.cloud>


          tests

c3b4000

Signed-off-by: razzle <harry@razzle.cloud>


          zarf tools kubectl --> e2e.Kubectl

c32745c

Signed-off-by: razzle <harry@razzle.cloud>


          parallelize test 20

b10dc9d

Signed-off-by: razzle <harry@razzle.cloud>

Noxsios added 7 commits

May 31, 2023 15:33


          changes from review

d847c54

Signed-off-by: razzle <harry@razzle.cloud>


          update example local chart to use podinfo

f3c5e23

Signed-off-by: razzle <harry@razzle.cloud>


          re-index tests

c6072e6

Signed-off-by: razzle <harry@razzle.cloud>


          merge bb yolo example into bb example

c47ca81

Signed-off-by: razzle <harry@razzle.cloud>


          merge main

82d0416

Signed-off-by: razzle <harry@razzle.cloud>


          fix test 00

faf3762

Signed-off-by: razzle <harry@razzle.cloud>


          fix test 08

8558d24

Signed-off-by: razzle <harry@razzle.cloud>

Racer159 requested changes

View reviewed changes

examples/big-bang/README.md Outdated Show resolved Hide resolved

src/test/e2e/40_deprecated_component_scripts_test.go Outdated Show resolved Hide resolved

src/test/e2e/41_deprecations_set_variables_test.go Outdated Show resolved Hide resolved

Noxsios and others added 11 commits

May 31, 2023 18:46


          Update examples/big-bang/README.md

7fa213a

Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>


          fix test 28

0a4add2

Signed-off-by: razzle <harry@razzle.cloud>


          fix test 51

ffa54b7

Signed-off-by: razzle <harry@razzle.cloud>


          fix test 51

f588949


          cleaner 51

Signed-off-by: razzle <harry@razzle.cloud>


          Merge branch 'main' into 1168-review-docs-examples

2edd291


          fix 51

76ebcb0

Signed-off-by: razzle <harry@razzle.cloud>


          fix 28 on windows

5b6b27f

Signed-off-by: razzle <harry@razzle.cloud>


          fix yolo example

a737759

Signed-off-by: razzle <harry@razzle.cloud>


          faster 29

98bc904

Signed-off-by: razzle <harry@razzle.cloud>


          fix docs

2a358fe

Signed-off-by: razzle <harry@razzle.cloud>

Racer159 requested changes

View reviewed changes

Contributor

Racer159 left a comment

one small change to the init package test.

src/test/e2e/20_zarf_init_test.go Outdated Show resolved Hide resolved

Noxsios added 2 commits

June 1, 2023 10:44


          revert

254f613

Signed-off-by: razzle <harry@razzle.cloud>


          lint

8a27b01

Signed-off-by: razzle <harry@razzle.cloud>

Racer159 approved these changes

View reviewed changes

Contributor

Racer159 left a comment

lgtm

Racer159 requested a review from YrrepNoj

June 1, 2023 18:22

YrrepNoj dismissed their stale review

June 1, 2023 20:52

stale

YrrepNoj approved these changes

View reviewed changes

YrrepNoj approved these changes

View reviewed changes

Racer159 merged commit 4d53e40 into main

Racer159 deleted the 1168-review-docs-examples branch

June 1, 2023 20:52

renovate bot mentioned this pull request

Update all dependencies jacobbmay/test-renovate#6

Open

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet