Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big Bang OCI compose and Big Bang --differential fix #1762

Merged
merged 25 commits into from
Jun 3, 2023
Merged

Conversation

Racer159
Copy link
Contributor

Description

This fixes an issue with BB not respecting differentials and adds the ability to OCI compose the BB extension.

Related Issue

Fixes #1746

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 0f42339
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/647a7bd50939cc0008951880

@Racer159 Racer159 added the needs-tests PR Label - Tests required to merge label May 31, 2023
@Racer159 Racer159 marked this pull request as draft May 31, 2023 21:29
@Racer159 Racer159 removed the needs-tests PR Label - Tests required to merge label Jun 1, 2023
@Racer159 Racer159 marked this pull request as ready for review June 2, 2023 20:03
@Racer159 Racer159 requested a review from Madeline-UX as a code owner June 2, 2023 20:03
src/pkg/packager/compose.go Outdated Show resolved Hide resolved
src/pkg/packager/extensions.go Outdated Show resolved Hide resolved
src/pkg/packager/publish.go Outdated Show resolved Hide resolved
Co-authored-by: razzle <harry@razzle.cloud>
src/pkg/packager/extensions.go Outdated Show resolved Hide resolved
Racer159 and others added 4 commits June 2, 2023 15:30
Co-authored-by: razzle <harry@razzle.cloud>
Co-authored-by: razzle <harry@razzle.cloud>
Co-authored-by: razzle <harry@razzle.cloud>
src/pkg/packager/publish.go Outdated Show resolved Hide resolved
YrrepNoj
YrrepNoj previously approved these changes Jun 2, 2023
Copy link
Contributor

@Noxsios Noxsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Noxsios Noxsios enabled auto-merge (squash) June 2, 2023 23:48
@Noxsios Noxsios merged commit d644c14 into main Jun 3, 2023
@Noxsios Noxsios deleted the 1746-oci-bb-compose branch June 3, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCI Compose Extensions (BigBang)
3 participants