Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Importing OCI Components w/ no local resources #1774

Merged

Conversation

Noxsios
Copy link
Contributor

@Noxsios Noxsios commented Jun 2, 2023

Description

Fix importing components that do not have any local resources via OCI.

Related Issue

Fixes #1772

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Noxsios added 2 commits June 2, 2023 06:25
Signed-off-by: razzle <harry@razzle.cloud>
Signed-off-by: razzle <harry@razzle.cloud>
@Noxsios Noxsios linked an issue Jun 2, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Jun 2, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 713d452
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/647a53f66434600008a02290

@Noxsios Noxsios changed the title 1772 zarf skeleton doesnt like components without local files Fix Importing OCI Components w/ no local resources Jun 2, 2023
@Noxsios Noxsios marked this pull request as ready for review June 2, 2023 12:09
src/pkg/packager/compose.go Outdated Show resolved Hide resolved
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 merged commit 3a07d4b into main Jun 2, 2023
@Racer159 Racer159 deleted the 1772-zarf-skeleton-doesnt-like-components-without-local-files branch June 2, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zarf Skeleton doesn't like components without local files
2 participants