Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1806 - Update Nerd Notes #1807

Merged
merged 4 commits into from
Jun 12, 2023
Merged

1806 - Update Nerd Notes #1807

merged 4 commits into from
Jun 12, 2023

Conversation

cmwylie19
Copy link
Contributor

Description

Small update around Zarf-Agent

Related Issue

Fixes #1806

Relates to #1806

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Jun 12, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit c983dcc
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/648760188931100008d78884
😎 Deploy Preview https://deploy-preview-1807--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Racer159
Racer159 requested changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small clarifications

docs/12-contribute-to-zarf/3-nerd-notes.md Outdated Show resolved Hide resolved
cmwylie19 added 4 commits June 12, 2023 14:06
@cmwylie19
[TASK] explanation of zarf agent
cbf1ecd 
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
@cmwylie19
[TASK] remove stale content around zarf-agent
69ba3f9 
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
@cmwylie19
[TASK] simplify explanation
91ccc89 
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
@cmwylie19
[TASK] Update verbage based on PR suggestion
c983dcc 
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
cmwylie19
cmwylie19 commented Jun 12, 2023
View reviewed changes
Copy link
Contributor Author

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added the changes locally and pushed bc i wasn't sure if I committed in the UI if it would be verified.

@Racer159
Copy link
Contributor

i added the changes locally and pushed bc i wasn't sure if I committed in the UI if it would be verified.

No problem, and it would verify it (GitHub signs it for you from the web UI).

@Racer159 Racer159 merged commit 472c216 into zarf-dev:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Racer159 Racer159 Racer159 approved these changes

@Madeline-UX Madeline-UX Awaiting requested review from Madeline-UX

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@YrrepNoj YrrepNoj Awaiting requested review from YrrepNoj

@Noxsios Noxsios Awaiting requested review from Noxsios

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Nerd Notes
2 participants
@cmwylie19 @Racer159