1582 error handling for package deployment #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… creating a multi-stream that sends to logfile, stderr, and stream and allows for resetting the default after the stream closes (probably could be in the config). Updated the deploy stream withh a multiwriter and resets to default, fix deployment stream to handle larger buffer using Reader and readline. Update the deployment page to use all colors from stream, update the xterm frame styling.
…ploy stream using ansi-to-html as it is a much smaller dependency and still meets the needs for the deploystream in addition to allowing much simpler custom styling
… the ansi color palette from figma to the ansi-display. Update font size, padding, scrolling behavior.
…tle and set to the warning or error variant depending on the output.
4 tasks
✅ Deploy Preview for zarf-docs canceled.
|
…page. Create yaml-drawer component. Create zarf-prism-theme. Moved the ansi-display to lib. Updated get deployed packages to log an error instead of bailing
…while deploying, fixed the expanded search to ensure the button is connected prior to clicking in the deploy tests.
mike-winberry
requested review from
jeff-mccoy,
YrrepNoj,
Racer159 and
Noxsios
as code owners
…he init package sbom in the pipeline.
…ing test failures.
YrrepNoj
reviewed
Jun 21, 2023
…errors and a slice of types.DeployedPackage to allow for better error handling when some packages are unmarshaled and others are not. Update packages list.go and cmd package.go to reflect the changes. Update lang english.go with CmdPackageListUnmarshalErr for use when one or more unmarshaling errors occur when getting deployed zarf packages.
…order to properly send all the output in the stream. Fix ui deploy page to properly close the stream when navigating away from the route.
…oyed package menu
2 tasks
2 tasks
YrrepNoj
suggested changes
Jun 22, 2023
Co-authored-by: Jonathan Perry <YrrepNoj@gmail.com>
Co-authored-by: Jonathan Perry <YrrepNoj@gmail.com>
Co-authored-by: Jonathan Perry <YrrepNoj@gmail.com>
YrrepNoj
approved these changes
Jun 22, 2023
Racer159
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Approving for now since this is a step forward though after playing with it a bit some of the design pieces are missing (particularly red error handling).
Top Left - Design File
Top Right - As Implemented in WebUI
Bottom Left - The Web UI log output
Bottom Right - The CLI log output for that failing package
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1582
#1606
Type of change
Checklist before merging