Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual Workflow For Publishing Application Packages to GHCR #1856

Merged
merged 29 commits into from
Jul 27, 2023
Merged

Manual Workflow For Publishing Application Packages to GHCR #1856

merged 29 commits into from
Jul 27, 2023

Conversation

YrrepNoj
Copy link
Contributor

@YrrepNoj YrrepNoj commented Jun 27, 2023 •
edited
Loading

This PR introduces a workflow that can be manually triggered to publish a package to GHCR using the defense unicorns org token.

Related to #758

@netlify
Copy link

netlify bot commented Jun 27, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit f6df16b
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/64c2d32ac2926800081cf745

Racer159
Racer159 requested changes Jun 27, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Racer159
Racer159 requested changes Jun 30, 2023
View reviewed changes
.github/workflows/publish-application-packages.yml Outdated Show resolved Hide resolved
.github/workflows/publish-application-packages.yml Outdated Show resolved Hide resolved
.github/workflows/publish-application-packages.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
.github/workflows/publish-application-packages.yml Outdated Show resolved Hide resolved
Racer159
Racer159 previously approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now though likely this will also need the packages: write permission like the release workflow.

Racer159
Racer159 requested changes Jul 6, 2023
View reviewed changes
src/config/lang/english.go Outdated Show resolved Hide resolved
src/config/lang/english.go Outdated Show resolved Hide resolved
@YrrepNoj YrrepNoj requested review from mike-winberry, Madeline-UX and a team as code owners July 11, 2023 17:59
Noxsios
Noxsios suggested changes Jul 22, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
src/types/component.go Show resolved Hide resolved
docs/2-the-zarf-cli/100-cli-commands/zarf_package_deploy.md Outdated Show resolved Hide resolved
.github/workflows/publish-application-packages.yml Show resolved Hide resolved
Racer159
Racer159 requested changes Jul 24, 2023
View reviewed changes
.github/workflows/publish-application-packages.yml Outdated Show resolved Hide resolved
src/config/lang/english.go Outdated Show resolved Hide resolved
Racer159
Racer159 previously approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Noxsios
Noxsios previously approved these changes Jul 24, 2023
View reviewed changes
@Racer159 Racer159 enabled auto-merge (squash) July 24, 2023 18:33
@Racer159 Racer159 disabled auto-merge July 24, 2023 18:37
@YrrepNoj YrrepNoj dismissed stale reviews from Noxsios and Racer159 via cd974e6 July 24, 2023 18:55
Racer159
Racer159 previously approved these changes Jul 24, 2023
View reviewed changes
@Racer159 Racer159 enabled auto-merge (squash) July 24, 2023 18:56
Racer159
Racer159 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 merged commit 355235c into main Jul 27, 2023
@Racer159 Racer159 deleted the 758-publish-example-packages branch July 27, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Racer159 Racer159 Racer159 approved these changes

@Noxsios Noxsios Noxsios left review comments

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@mike-winberry mike-winberry Awaiting requested review from mike-winberry

@Madeline-UX Madeline-UX Awaiting requested review from Madeline-UX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YrrepNoj @Racer159 @Noxsios