Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix inline publish #1857

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Hotfix inline publish #1857

merged 5 commits into from
Jun 27, 2023

Conversation

Noxsios
Copy link
Contributor

@Noxsios Noxsios commented Jun 27, 2023

Description

Fixes ReferenceFromMetadata not properly receiving the arch suffix.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Noxsios added 2 commits June 27, 2023 12:49
@Noxsios
hotfix reference from metadata uses empty arch suffix
cba2247 
Signed-off-by: razzle <harry@razzle.cloud>
@Noxsios
trim oci://
8b81c89 
Signed-off-by: razzle <harry@razzle.cloud>
@netlify
Copy link

netlify bot commented Jun 27, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 192bd49
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/649b3ab906ddb40008262cf4

Noxsios and others added 3 commits June 27, 2023 13:00
@Noxsios
test coverage
b062455 
Signed-off-by: razzle <harry@razzle.cloud>
@Noxsios
confirm
501b903 
Signed-off-by: razzle <harry@razzle.cloud>
@Racer159
Merge branch 'main' into hotfix-inline-publish
192bd49
Racer159
Racer159 approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 enabled auto-merge (squash) June 27, 2023 19:46
@Racer159 Racer159 merged commit c36d60c into main Jun 27, 2023
@Racer159 Racer159 deleted the hotfix-inline-publish branch June 27, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Racer159 Racer159 Racer159 approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@YrrepNoj YrrepNoj Awaiting requested review from YrrepNoj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Noxsios @Racer159